[PATCH] Support for KUrl in KConfigXT and KCModule's

[Aaron J. Seigo]

On March 19, 2007, Andreas Pakulat wrote:
> as proposed I added support for KUrl to KConfigXT and
> KConfigDialogManager, the attached patch adds a new
> KConfigSkeletonItem and adds the two missing signals for
> change-notification to KConfigDialogManager. Luckily KUrlRequester

please follow the kdelibs style guidelines. otherwise, looks good.

> I'm not sure wether KUrl::List is needed as I don't see any widgets that
> work on such a type, but it should be relatively easy to add support for
> that.

widgets are only half the question; kconfigxt is used without UIs as well =)

> One problematic thing is that any app that wants to use KUrl wrapped in
> a QVariant needs to call qRegisterMetaType<KUrl>("KUrl");. I think this
> should be somewhere in kconfig or maybe even KUrl code, but I'm not sure
> where to put it, so any comments welcome regarding that. KUrl
> constructor might be a good enough place, as calling the function
> multiple times doesn't seem to be a problem.

except for the added overhead of the call since KUrl needs to be fast. it 
doesn't look like the overhead is all that great, but still =) though, yes, i 
do think we should register these things just to make application code easier 
to write. i don't like the idea of such magical lines needing to be uttered 
everywhere.

one place that might be of lowermpact than kurl's ctor is in KApplication? we 
could register the qvariants we want to be considered 'first class' items in 
kde apps. kurl would be amongst those, imho.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

Full time KDE developer sponsored by Trolltech (http://www.trolltech.com)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070319/39f4d055/attachment.sig>