[PATCH] seeking for KIO's sftp protocol
Matthias Kretz
kretz at kde.org
Fri Mar 16 18:16:42 GMT 2007
Hi,
please review the attached patch. I tested it successfully to seek in remote
files with Phonon (you can now watch videos over sftp), but I didn't test
writing at all. Are there any testcases for FileJobs?
A few more questions:
The file slave in CMD_READ leaves the cmd loop and closes the file when it
reaches eof. Should it not stay in the cmd loop and wait for a close command?
FileJob *KIO::open(KUrl, int access)
Should the access parameter be a QFlags instead? Perhaps QIODevice::OpenMode?
Currently only read and write are documented but the file slave also
implements 0x04 as O_CREAT. Is that a pattern from some other KIO code?
--
________________________________________________________
Matthias Kretz (Germany) <><
http://Vir.homelinux.org/
MatthiasKretz at gmx.net, kretz at kde.org,
Matthias.Kretz at urz.uni-heidelberg.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sftp-seeking.patch
Type: text/x-diff
Size: 5711 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070316/d76dd35f/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070316/d76dd35f/attachment.sig>
More information about the kde-core-devel
mailing list