KDialog + KPage* d-ptr cleanup and fixes

Matthias Kretz kretz at kde.org
Fri Jun 22 23:12:00 BST 2007


Hi,

while working on KSettings::Dialog I had to look into KDialog and all KPage* 
classes which resulted in the following two patches:
1. http://vir.homelinux.org/kdeui-dialogs.patch
2. http://vir.homelinux.org/kdeui-paged.patch

The first one is rather straightforward. It makes use of the d-pointer pattern 
used throughout Qt in order to be able to inherit the d-pointer in all 
derived classes (like KDialog -> KPageDialog -> KCMultiDialog -> 
KSettings::Dialog).

Patch 2 is three times as big and applies the same d-pointer pattern to 
KPageDialog, KPageModel -> KPageWidgetModel, KPageView -> KPageWidget.
API changes:
- KPageView::setModel()/::model() use a QAbstractItemModel* instead of 
KPageModel* now since otherwise you cannot use any of the Qt interview 
convenience classes with KPageView. KPageModel only adds two enum values to 
QAbstractItemModel.
- the KPageDialog ctor that takes a KPageWidget* now reparents the KPageWidget 
to this as it's impossible to create the KPageWidget with this as parent.
- added setEnabled/isEnabled to KPageWidgetItem which enables/disables the 
entry in the tree/list and the widget

I'd like to commit on monday, ok?

-- 
________________________________________________________
Matthias Kretz (Germany)                            <><
http://Vir.homelinux.org/
MatthiasKretz at gmx.net, kretz at kde.org,
Matthias.Kretz at urz.uni-heidelberg.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070623/78e205c3/attachment.sig>


More information about the kde-core-devel mailing list