[proposed PATCH] new comparison method in KConfigSkeletonItem (was: Custom-type QVariant comparison in KConfigDialogManager)

Constantin Berzan exit3219 at gmail.com
Mon Jun 18 11:51:20 BST 2007


On Monday 18 June 2007 13:43, Thiago Macieira wrote:
> 
> Constantin Berzan said:
> >> http://pastebin.com/930652
> >
> > So, if there are no voices against it, can someone commit it please?
> 
> The patch looks good. Next time, though, please attach the patch. The
> pastebin will disappear soon and we won't have a record anymore of what
> you posted. What happens to people who read this email tomorrow?

Point taken.
Just so I know next time: what is the size threshold beyond which a patch 
should be sent compressed?

> 
> Today is Monday, so it can be committed. It changes the virtual table
> layout, so it's BIC.
> 
> Constantin: if you don't have an SVN account, ask someone to commit it for
> you *today*.
> 
> -- 
>   Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
>     PGP/GPG: 0x6EF45358; fingerprint:
>     E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
> 
> 
> 

-- 
http://ascending.wordpress.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdelibs-isequal.patch
Type: text/x-diff
Size: 15524 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070618/197a0980/attachment.patch>


More information about the kde-core-devel mailing list