[CLucene-dev] the importance of -ansi

[Ben van Klinken]

Thanks Jos, will keep it in mind. I do recall some issues with the
floats and doubles. But I'm still not sure how you are supposed to use
these definitions correctly.

An insightful remark about sending me back to school :-)... to be
truthful, this was a project I used to learn c++ many years ago... no
doubt it could have been done better.

it's interesting that someone writing a mathdef.h makes the same
mistakes as i did... no wonder i learnt bad habits, since they way i
learnt was by looking at other people's code :) live and learn I
say...

A major refactor of CLucene would be a nice thing to see. Especially
if it came out being equivalent to lucene 2.1. But as Jos points out,
there's a lot of time required to do something like that... these days
its hard for me to find any time for CLucene. However, anyone
interested in taking up a task like this would get my full support!

cheers

ben

On 16/06/07, Jos van den Oever <jvdoever at gmail.com> wrote:
> 2007/6/16, Thiago Macieira <thiago at kde.org>:
> > I thought it was a stale build because that had happened to me once. I was
> > getting crashes I could not understand and valgrind was reporting memory
> > violations ("address is 0 bytes after a block of XX bytes at 0xHHHHHH")
> > that shouldn't be there. That's exactly the same symptom Jos was having.
> >
> > My problem was fixed by removing all .o and rebuilding.
> >
> > But when I started reading CLucene code, I was thinking "whoever released
> > this should be sent back to school". Sorry, but the code is nasty. It
> > changes class sizes according to macros like _DEBUG. That's just asking
> > for trouble.
> >
> > That is still my opinion. CLucene needs to be cleaned up so that it does
> > NOT depend on macros.
> >
> > In any case, I'd never have guessed math.h does the same thing. Then
> > again, I'd never heard about float_t. Why is that being used at all? It's
> > nowhere in glibc's TeXinfo documentation.
> CLucene will never win a beauty pageant, that's for sure. The code is
> remarkably stable though (when built right). The reason for that is
> that it is used a lot. CLucene is so nice because it is really fast.
> Lucene 2.1 is a nice point for starting on a clean new CLucene
> version, but good luck finding somebody with the time to implement it.
>
> Currently CLucene is the best backend I know, but if a better one
> comes around we can switch relatively easily. A backend requires 3
> classes to be implemented. Right now we are expanding our general
> backend unit tests to ensure quality and fast development of all
> backends.
>
> Cheers,
> Jos
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> CLucene-developers mailing list
> CLucene-developers at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/clucene-developers
>