KDirWatch: request for a small change into the API

Thiago Macieira thiago at kde.org
Fri Jul 27 14:35:03 BST 2007


Olivier Goffart wrote:
>> +   enum Action { DoNothing = -1,
>
>You probably mean  = 0
>
>> +                 Recursive =  0x001,
>> +                 WatchFiles = 0x002
>> +   };
>
>The documentation of this enum is missing

Also, please try and find better names

Like:
	enum WatchMode {
		WatchDirOnly = 0,
		WatchFiles = 0x01,
		WatchSubDirs = 0x02
	};

Since that's supposed to be OR-able flags, I take that "Recursive" 
without "files" means "watch this dir and its subdirs but not the files 
on them", whereas WatchFiles | WatchSubdirs = "watch everything".

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070727/0e05e5ad/attachment.sig>


More information about the kde-core-devel mailing list