[PATCH] kdelibs kio::KDirWatch

[Andreas Pakulat]

On 25.07.07 10:30:31, Flavio Castelli wrote:
> On Wednesday 25 July 2007 01:14:01 Andreas Pakulat wrote:
> > I think inotify should be preferred over fam/gamin, however I do
> > understand your point. Maybe a configuration option to change this
> > preference would be good?
> 
> I agree with you, I think I can add this possibility.
> What do you suggest in order to accomplish this task? Maybe I can add a new 
> optional parameter to addDir() and addFile() ?
> BTW, with API freeze I can't do such a modification.

I meant a config option that can be set during cmake time. I don't know
how the priority is set inside KDirWatch, but if its just a few places
you can do something like


#ifdef PREFER_FAMD
  <code to prefer famd>
#else
  <code to prefer inotify over famd>
#endif

And in the CMakeLists.txt:

if( KDIRWATCH_PREFER_FAMD )
  add_definitions(-DPREFER_FAMD)
endif( KDIRWATCH_PREFER_FAMD )

That would allow to choose which method to use on kdelibs-buildtime, I
don't think it makes sense to let the User of the class choose on each
addDir() call.

Andreas

-- 
You too can wear a nose mitten.