Request for Review: KExpandableWidget into kdeui

[Daniel Molkentin]

Hi list,

sorry that this mail makes it on the last date possible but it's finally 
there, hussah!

I am asking to include KExpandableGroupBox [1] (screenshot at [2]) into SVN.  
It behaves similar to a QGroupBox,  but is collapsed by default and can be 
expanded. Inside a QScrollArea it is thus very useful for adding advanced 
options. The only difference to QGroupBox is that the inner Widget is being 
set via setWidget(), rather than via an explicit layout.  This cannot be 
changed from my POV, please tell me if I am wrong. Otoh, I think this is a 
fairly minor issue. Did I mention it comes with a fancy expand animation? :-)

The class lives in playground since about two years and I recently cleaned it 
up: it has API docs, is valuecopy-protected, the member vars are pimpl'ed, 
the ctor is explicit and the API is const correct (at least as far as I can 
see). It also provides a demo (in tests/).

The class is being used inside plasma (holds a private copy) and I have seen 
at least in KToon (a non KDE SVN project) using it [3], both under its old 
name "CollapsibleWidget". Also, it will probably use a lot more in the future 
as we come to fix up KControl modules.

So can anyone please have a look? Any objections against having the class in 
kdeui? I know that the animation could be improved, but that would not affect 
the API.

Cheers,
  Daniel

[1]  http://websvn.kde.org/trunk/playground/libs/ui/collapsiblewidget/
[2]  http://developer.kde.org/~danimo/screenies/kexpandablewidget/
[3]  
http://www.koders.com/cpp/fidC83C8C581A206DC34D4F514E44741EB719D78EC6.aspx
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070724/97156068/attachment.sig>