[PATCH] remove UDSEntry from the public KIO API?

Thiago Macieira thiago at kde.org
Mon Jul 23 13:43:59 BST 2007


nf2 wrote:
>Thiago Macieira wrote:
>> This hides the details of UDSEntry and UDSField from the public. The
>> question is now? Should we commit? Norbert, does it help towards your
>> goal?
>
>Cool. I have seen you have also fixed the KioSlaveTest (which i have
>just commented out). And udsentry.cpp looks a lot nicer now.
>
>I think the patch should be commited - everything which makes the
>KIO-API more generic and extensible (without having to break the API)
>will help you in the future. No matter if the future is GVFS or not.

I'm not doing a "commit if no objections" on this one.

Someone else please OK this within the next 12 hours, or this patch will 
be out of KDE until KDE 5.0.

For ease of reading the patch, here's the most relevant part.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdelibs-udsentry-simple.diff
Type: text/x-diff
Size: 20842 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070723/28c5a852/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070723/28c5a852/attachment.sig>


More information about the kde-core-devel mailing list