[PATCH] API review of KCalendarSystem* and KDate* widgets

[John Layt]

On Friday 20 Jul 2007, Andreas Hartmetz wrote:
> Well, that does not sound nice. People will need to write calls like
> dayString(dateFormat == fancyDateFormat)
> which I'd call unnecessary manual conversion of types, and it goes against
> the "no bools in API" policy.
>
> You could, for example, deprecate the old methods and implement the new API
> and then start "porting", eventually removing the old API. There is a
> chance that this will pass as a necessary evil BIC change. Or you leave out
> the "removing deprecated API" part.
> Another, less convenient, option would be to recruit some people on this
> mailing list to port some module each. The work should be really simple and
> need no more than an hour or so per module, I guess.
> I volunteer for "something" if it's less than 100 calls to port :)
> lxr apparently isn't perfect, and I prefer to check out most of svn.kde.org
> and do a grep -R to find the calls in such a situation. Grep to a file,
> look for false positives and filter them out etc.

Good point, not sure why I didin't think of that, seeing as it's what I did 
with setYMD/setDate...

I'll write the new methods tonight, deprecate the old ones, and re-post the 
patches tomorrow.  I'll leave it to wiser heads to decide whether to remove 
the old or just leave as deprecated.

I might re-use the KLocale::DateFormat enum for the purpose.

John.

--

Send instant messages to your online friends http://au.messenger.yahoo.com