Return types of KCompositeJob::removeSubjob() and KJob::removeSubjob()

[Kevin Ottens]

Le lundi 09 juillet 2007, Richard Dale a écrit :
> KCompositeJob::removeSubjob() is returns a boolean, while
> KJob::removeSubjob() is a void method.

I assume you mean KIO::Job::removeSubJob().

> Should they both either be voids or 
> bools? I can't see anywhere in kdelibs where the reply value from
> KCompositeJob::removeSubjob() is tested.

The main point for having KCompositeJob::removeSubJob() was to allow rejecting 
some of the add/removeJob operations if needed. But that looks fine to me if 
a subclass wants to have a specific version with no return value (which is 
the case of KIO::Job).

Regards.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070709/5c7a11b6/attachment.sig>