Is it "Perl++"? kstyles/oxygen/genpixmaps.cpp

[Kevin Ottens]

Le mercredi 04 juillet 2007, Thiago Macieira a écrit :
> Jaroslaw Staniek wrote:
> >Hi
> >Oxygen is disabled for win32 but neither it compile on gcc...
> >see kstyles/oxygen/genpixmaps.cpp
>
> Fixed.
>
> s/\$(\d)/_\1/g

And actually it doesn't fix the fact that it's probably one of the worst piece 
of code we have in kdelibs, and AFAIK never got discussed anywhere before 
being dropped in kdelibs.

I also has quite some missing copyright headers missings, licence errors, the 
history of the code got broken when moved, etc.

Notified the author about it, and never got even a reply. To this day those 
issues aren't fixed.

If I'm wrong on any of the previous point please educate me. But actually I'm 
tempted to propose to remove this piece of code from kdelibs until it's:
1) properly discussed
2) the worst issues are fixed

I rarely rant, but it's on such case. Sorry for the bother, and thanks for 
your attention.

Regards.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070704/7f87b533/attachment.sig>