Is it "Perl++"? kstyles/oxygen/genpixmaps.cpp

Thiago Macieira thiago at kde.org
Wed Jul 4 10:49:11 BST 2007


Dirk Mueller wrote:
>On Wednesday, 4. July 2007, Thiago Macieira wrote:
>> >Oxygen is disabled for win32 but neither it compile on gcc...
>> >see kstyles/oxygen/genpixmaps.cpp
>>
>> s/\$(\d)/_\1/g
>
>I don't think this is a good idea, as it uglifies the code badly. use at
> least something that makes it easier to see that "_1" is not a number
> but a variable (_ is very easy to visually confuse with a space).
>
>I would suggest "f" or "s".

Ok, I'll do that.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070704/624a3385/attachment.sig>


More information about the kde-core-devel mailing list