KJob modifications

Kevin Ottens ervin at kde.org
Wed Jan 31 21:24:18 GMT 2007

Le Mercredi 31 Janvier 2007 22:08, Rafael Fernández López a écrit :
> I had some minutes to write this patch, and to know what you think about
> it.

At a glance, I have only two comments with this patch:
 - Q_DECLARE_OPERATORS_FOR_FLAGS( KJob::Capabilities ) is missing after the 
KJob class declaration in kjob.h
 - *Maybe* we want CanKill and CanPause in the enum? Because I somehow doubt 
that we'll find "*able" forms for all the capabilities (of course the opinion 
of a native speaker would be a plus here).

Other than that it looks fine to me.

Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070131/a44c332c/attachment.sig>

More information about the kde-core-devel mailing list