visibility-inlines-hidden

Thomas Zander zander at kde.org
Tue Jan 23 12:47:35 GMT 2007


I see a patch has gone into trunk/kdelibs to enable this feature.
Unfortunately it doesn't detect compilers that don't support this propertly. 
So my first link in kdelibs failed.

Reading the code I think a thinko has been made.  The test-source will fail to 
compile when the compiler doesn't support this feature. But if it does then 
the variable GCC_VISIBILITY_INLINES_HIDDEN_BUG is set. Which is a bit of a 
misnomer as the compile succeeding means that there is no bug. (it fails to 
compile properly on my edgy 4.1.2 compiler)

Due to that I think the cmake file should be altered with the following patch.
Can I commit?
-- 
Thomas Zander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: inlines.diff
Type: text/x-diff
Size: 959 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070123/6bb0112a/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070123/6bb0112a/attachment.sig>


More information about the kde-core-devel mailing list