Normalizing signals and slots

[Thiago Macieira]

jos poortvliet wrote:
>Op zondag 14 januari 2007, schreef Matt Rogers:
>> I disagree. Normalizing signals and slots doesn't make that much of a
>> real difference in terms of speed. We don't gain that much by doing it
>> for more than kdelibs and parts of kdebase.
>
>now i'm of course not qualified to comment on this, but i wonder - how
> much work is it? i mean, maybe it's not worth changing stuff for, but
> it could be part of coding guidelines?

Requiring programmers to normalise is not worth it. Sometimes, the code 
looks uneven or just plain ugly when compared to the rest of the code. 
But the most important aspect is that we're humans and sometimes we get 
it wrong.

Making a mistake in a slot or signal name is worse than simply allowing Qt 
to normalise the copy/paste from the .h file.

That's why running a script is probably better. If we do it once just 
before the KDE 4.0 release and then once per year, we should be mostly 
fine already.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070114/e6408d77/attachment.sig>