kuiserver refactoring (again)

David Faure faure at kde.org
Sun Feb 4 23:24:31 GMT 2007


On Monday 05 February 2007, Rafael Fernández López wrote:
> If a KJob was started (well or another class that inherits it), and while in
> progress, the app crashes, the job will remain forever on the kuiserver.
> I've fixed it emitting the finished signal on the destructor. I think this
> is not as good as we may expect. And of course, I want to know what you
> think.

This makes no sense. When an application crashes, it just crashes, no destructors
are being run.

Other than that, the patch looks ok to me.

Ah, one bug in the test code:
 timer(new QTimer()), clockTimer(new QTimer()), 
Those timers are leaked. Pass "this" as parent, or make them non-pointers.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list