kwallet 3.5 svn fails 'make check' if not installed

Matthew Woehlke mw_triad at users.sourceforge.net
Fri Feb 2 22:02:14 GMT 2007


'make check' for kwallet fails if done before 'make install'. Since I 
didn't run into this building 3.5.6 (I am currently building svn 
branches/KDE/3.5) this looks like a recent regression.

Fixed by applying the following... Ok to commit?

Index: tests/Makefile.am
===================================================================
--- tests/Makefile.am   (revision 629402)
+++ tests/Makefile.am   (working copy)
@@ -4,13 +4,17 @@
  check_PROGRAMS = kwalletasync kwalletsync kwalletboth

  kwalletasync_SOURCES = kwalletasync.cpp kwallettest.cpp
-kwalletasync_LDFLAGS = -no-undefined $(all_libraries) $(KDE_RPATH)
-kwalletasync_LDADD = $(LIB_QT) $(LIB_KDECORE) -lkwalletclient
+kwalletasync_LDFLAGS = -no-undefined $(KDE_RPATH) $(all_libraries)
+kwalletasync_LDADD = $(top_builddir)/kwallet/client/libkwalletclient.la \
+       $(LIB_KDECORE) $(LIB_QT)

  kwalletsync_SOURCES = kwalletsync.cpp
-kwalletsync_LDFLAGS = -no-undefined $(all_libraries) $(KDE_RPATH)
-kwalletsync_LDADD = $(LIB_QT) $(LIB_KDECORE) -lkwalletclient
+kwalletsync_LDFLAGS = -no-undefined $(KDE_RPATH) $(all_libraries)
+kwalletsync_LDADD = $(top_builddir)/kwallet/client/libkwalletclient.la \
+       $(LIB_KDECORE) $(LIB_QT)

  kwalletboth_SOURCES = kwalletboth.cpp kwallettest.cpp
-kwalletboth_LDFLAGS = -no-undefined $(all_libraries) $(KDE_RPATH)
-kwalletboth_LDADD = $(LIB_QT) $(LIB_KDECORE) -lkwalletclient
+kwalletboth_LDFLAGS = -no-undefined $(KDE_RPATH) $(all_libraries)
+kwalletboth_LDADD = $(top_builddir)/kwallet/client/libkwalletclient.la \
+       $(LIB_KDECORE) $(LIB_QT)
+INCLUDES = -I$(top_srcdir)/kwallet/client

-- 
Matthew
OFFICER throws a tear gas grenade at you. You start to feel nauseous. 
You need fresh air quickly.
 > OPEN WINDOWS
Sorry, I have a philosophical objection to Microsoft products.





More information about the kde-core-devel mailing list