[PATCH] Mac OS X application icon support

[Saro Engels]

Alexander Neundorf schrieb:
> On Saturday 29 December 2007, Christian Ehrlicher wrote:
>> Alexander Neundorf schrieb:
>>> On Saturday 29 December 2007, Christian Ehrlicher wrote:
>>>> Ralf Habacker schrieb:
>>>>> Harald Fernengel schrieb:
>>>>>> -----BEGIN PGP SIGNED MESSAGE-----
>>>>>> Hash: SHA1
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> similarly to KDE4_ADD_WIN32_APP_ICON, this patch adds a
>>>>>> KDE4_ADD_MACOSX_APP_ICON to KDE4Macros.cmake, so KDE applications
>>>>>> won't have the boring default icon when opened in Finder.
>>>>>>
>>>>>> Unfortunately, I can't reuse the WIN32_APP_ICON macro, since on
>>>>>> Windows, the app icon is 32x32 and it's compiled into the binary,
>>>>>> whereas on Mac, it's usually 128x128 and copied into the application
>>>>>> bundle at install time.
>>> Ok, we are in deep freeze, so actually this is too late.
>>> I know it doesn't make any sense to ask why nobody figured that out
>>> earlier. (and we discussed the freeze and release dates long enough
>>> already, so I don't feel like repeating this now).
>> We can wait until pre 4.0 - it does not affect linux at all.
> 
> Removing/renaming a macro affects all platforms.
> 
> ...
>>> Instead add:
>>>
>>> macro(KDE4_ADD_WIN32_APP_ICON)
>>>   message(FATAL_ERROR "KDE4_ADD_WIN32_APP_ICON() is deprecated,
>>>                    use KDE4_ADD_APP_ICON() instead")
>>>
>>> endmacro(KDE4_ADD_WIN32_APP_ICON)
>>>
>>> or use SEND_ERROR or FATAL_ERROR instead of STATUS for the message.
>>>
>>> If it's too late for removing the macro, then add the new one and change
>>> the old one:
>>>
>>> macro(KDE4_ADD_WIN32_APP_ICON)
>>>   message(STATUS "KDE4_ADD_WIN32_APP_ICON() is deprecated,
>>>                    use KDE4_ADD_APP_ICON() instead")
>>>   KDE4_ADD_APP_ICON(${ARGN})
>>> endmacro(KDE4_ADD_WIN32_APP_ICON)
>> Thx, we'll do this. As only Saro add those macros in kdeedu and kdegames
>> it should be easy to rename them. I'll ask the release team.
>>
>> @Harald: Do you need the macro for 4.0.x or ca you wait until 4.1?
> 
> If we wait until after 4.0 KDE4_ADD_WIN32_APP_ICON() has to work for KDE >= 
> 4.0 and additionally KDE4_ADD_APP_ICON() has to be supported for KDE >= 4.1.
> 
> So if possible, I'd prefer KDE4_ADD_APP_ICON() now.
For me it is the same - I just tested a bit icon adding right now. Many 
of the oxygen icons are still missing so I stopped working on it.
I would be glad though to have that macro working on MacOSX too.
> 
> Alex
> 
regards
SE