KPropertiesDialog needs a fix

[Jos Poortvliet]

On Dec 24, 2007 10:48 AM, David Faure <faure at kde.org> wrote:
>
> On Monday 24 December 2007, Andreas Pakulat wrote:
> > On 24.12.07 01:09:58, Aurélien Gâteau wrote:
> > > Rafael Fernández López wrote:
> > >
> > > > Hi all,
> > > >
> > > > Tonight I've been trying to fix KPropertiesDialog. Reminding:
> > > >
> > > > http://media.ereslibre.es/2007/10/propertiesdialog.png
> > > [snip]
> > > > So now, there are some possibilities:
> > > [snip]
> > > > - We could consider using QTabWidget instead of QTabBar for the
> > > > KPropertiesDialog (that is created after all the stuff on
> > > > kdelibs/kdeui/paged/kpageview_p.cpp).
> > >
> > > Attached patch does this: it makes KPropertiesDialog inherits from KDialog
> > > instead of KPageDialog and set a QTabWidget as the main widget.
> > > What do you think about this?
> >
> > Isn't this a BIC change and thus not possible anymore until KDE5?
>
> Hmm really? There have been some BIC changes not so long ago, IIRC...

I guess it depends on how much we think we need this, how dangerous it
is in terms of introducing new bugs, and how many ppl are willing and
capable of testing this patch ;-)

I personally think we need this but I can't say much about the risks
involved. I can however test the patch, which I did - it works great
and I was unable to crash anything.

> --
> David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
> Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
>