[PATCH] Scrollable page dialogs

Matthias Kretz kretz at kde.org
Wed Dec 19 16:17:30 GMT 2007

On Wednesday 19 December 2007, Aurélien Gâteau wrote:
> Hello,
> While working on SystemSettings module size problems, I thought it would be
> nicer to prevent the bottom button bar from scrolling. Digging in the code
> I realized I needed to patch KPageView, so it would impact all KDE dialogs.
> Attached are two patches, the kdeui one which adds scrollbars to KPageView
> if necessary, the other one removes QScrollArea from SystemSettings, as
> it's no longer needed.
> Here are a series of screenshots showing the difference. All shots were
> made using the default SystemSettings size.
> - Network / Proxy
> Before: http://img178.imageshack.us/img178/2037/beforenetworkproxyty8.png
> After: http://img178.imageshack.us/img178/950/afternetworkproxyhg5.png
> - Accessibility
> Before: http://img208.imageshack.us/img208/4717/beforea11ykq2.png
> After: http://img208.imageshack.us/img208/8915/aftera11ykz2.png
> As I said, this patch impacts all KDE KPageDialog instances. For example,
> the Konqueror settings dialog does not resize itself anymore[1] when
> switching between pages. Here is a screenshot:
> http://img179.imageshack.us/img179/8184/afterkonqsettingsht3.png
> Do you think this should go in? Or should I try to work on a patch which
> would only affect SystemSettings?

Does Systemsettings use a KPageView directly or does it use KCMultiDialog? 
Because the latter already implements the correct scrollbar behaviour AFAIR.

And I agree with Tobias that we should take care to not encourage this 
behaviour and therefore not add it to KPageView.

Matthias Kretz (Germany)                            <><
MatthiasKretz at gmx.net, kretz at kde.org,
Matthias.Kretz at urz.uni-heidelberg.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071219/74e4b17f/attachment.sig>

More information about the kde-core-devel mailing list