[PATCH] KProcess port of khelpcenter

Ralf Habacker ralf.habacker at freenet.de
Mon Dec 17 23:05:28 GMT 2007

Oswald Buddenhagen schrieb:
> On Sat, Dec 15, 2007 at 11:38:48PM +0100, Ralf Habacker wrote:
>> Oswald Buddenhagen schrieb:
>>> that's a bit slim - the user is left in the dark about the cause.
>> Displaying messages in the status bar does not help, they will be 
>> overwritten immediatly by other messages. Any better idea ?
> well, i consider this a serious enough condition to justify popping up a
> really annoying error message box. if the cache is optional, a "do
> not show again" checkbox would be appropriate.
I have added a comment about this todo because I would like to fix this 
in a second step - it may be that such a dialog box is required at other 
places too and if we have the basic kprocess stuff ported then we have 
an overview what this dialog requires to avoid duplicate work.
In the appended path I tried to fix the open issues.

Relating to the -- if (mainWindow)  -- case I found that mainwindow 
could be zero in the qt docs.

Q <qwidget.html>Widget * QApplication::activeWindow ()   [static]
"Returns the application top-level window that has the keyboard input 
focus, or 0 if no application window has the focus."

Any more issues becore I can commit it ? 
Please not that this port fixes much more cases as the former K3Process 
implementation (stderrr/stdout '\n' issues, not started condition, 
mainwindow zero check), that means the quality of the this code is much 
higher as before.


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: khelpcenter-kprocess-3.patch
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071218/0a7c889d/attachment.ksh>

More information about the kde-core-devel mailing list