[PATCH] Configuring global shortcuts

[Andreas Pakulat]

On 09.12.07 21:23:06, Kelvie Wong wrote:
> On Dec 9, 2007 3:24 PM, Andreas Pakulat <apaku at gmx.de> wrote:
> > On 09.12.07 19:21:40, Andreas Pakulat wrote:
> > > Hi,
> > >
> > > currently the kcontrol module to configure keyboard shortcuts is in bad
> > > shape (kdebase/workspace/kcontrol/keys). It would need porting to the
> > > new global kded module.
> > >
> > > I talked to Andreas Hartmetz a bit on IRC and his opinion is that
> > > there's no need for it, except for a few special cases like kwin, plasma
> > > and  some others that don't have a mainwindow-application themselves.
> > > For all other applications that want to provide global actions they can
> > > provide this via their normal shortcuts configuration.
> > >
> > > I tend to agree and thus wrote a very simple new module that allows to
> > > configure only global shortcuts. It replaces the current module.
> > >
> > > The code needs a BC change in KShortcutsEditor, which is in the first
> > > patch. It adds a new method to clear the list of actions the editor
> > > currently shows.
> > >
> > > The kcm itself, simply asks the kded module for all global shortcuts and
> > > creates a combobox with all components. Upon changing the component the
> > > shortcut editor gets the new list of actions for that component. The
> > > second patch can be applied to kdebase/workspace/kcontrol/keys to build
> > > the new kcm.
> > >
> > > Now to the problems (apart from the new method in the editor widget):
> >
> > Just in case somebody wonders why I'm posting this for inclusion in 4.0
> > at all: One part is is surely to deliver a working way to change
> > shortcuts for things like window-switching or desktop switching (and all
> > the others that kwin and others provides. The other reason is Bugreport:
> > http://bugs.kde.org/show_bug.cgi?id=153211 and a related thread here
> > from me. Allowing to change shortcuts with a kcm allows users to
> > workaround the X11-grabbing-problem, just in case its not fixed in time.
> > Without the kcm, people have to find the right kconfig file and change
> > it there.
> >
> With regards to that bug, why not just just put a workaround for it instead?
> 
> Either way, that shortcut will cause a freeze, so something like this
> (until the deeper problem is found) should be included into KDE4, even
> after enabling the global shortcuts.

Done, thanks for the patch. Revision 747205

Andreas

-- 
You have a will that can be influenced by all with whom you come in contact.