Changing nice layouts for html tags

[Urs Wolfer]

Hi

On Wednesday 05 December 2007 02.59:24 Rafael Fernández López wrote:
> Hi,
>
> I have seen that some code has been changed on kpluginselector for changing
> from widget layouts to html code. That could be more readable for coders
> (really ? I prefer code to html tags). 

IMHO it's easier to understand and fix / change small things in HTML code such 
is it used there.

> And then comes the worst thing: 
>
> Inconsistency.
>
> How many times we have to talk about this issue ? Run "kcmshell4 colors",
> select a "dark theme". Go to "About KDE", "About Dolphin" or whatever, and
> look at the freakin links.

Then we should go ahead and fix it! There are _many_ usecases of such HTML 
links (not only for URLs.) Should we port all them away from QLabel to 
KUrlLabel? IMHO not.

I don't know if this is possible in the current Qt stylesheet implementation. 
If not, we could probably request a change to have the link text color like a 
highlight color in the current color scheme. Unreadable links are not just in 
KDE a issue...

> Same now on kpluginselector. They become almost unreadable, why ? because
> of the so beloved html tags.

I don't agree. Please have a look at the attached screenshot. Which layout do 
you like more?

> Please rever those patches, and what's more, we should completely avoid the
> usage of (in)direct stylesheets, they are the root of evil :), mainly
> because you completely lose the control of the widget's appearance.

It's your code. Feel free to do so (I have seen that you have done so alrady 
before you got any answers).
I'm not entirely happy to see it reverted. For me the current widget layout 
looks very broken.

My comment for the about dialog change: We have had such a widgets layout in 
KDE 3 times. It was a mess of KUrlLabel, KActiveLabels and QLabels. The code 
was several hundred lines only for layouting these widgets... Now we have a 
IMHO clean and easy to maintain layout of all text on these dialogs.

Bye
urs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: html_widget_layouts.png
Type: image/png
Size: 21724 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071205/4341eace/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071205/4341eace/attachment.sig>