[PATCH] fix khotkey crashes

[Lubos Lunak]

On Tuesday 04 of December 2007, Andreas Pakulat wrote:
> On 04.12.07 16:14:19, Andreas Pakulat wrote:
> > Hi,
> >
> > Is this the right place for getting approval for khotkey patches? If not
> > I'd appreciate directions.
> >
> > The attached patch fixes the crashes when trying to create a new action
> > or group or trying to store those settings.
> >
> > May I commit this now or shall I wait until after the tagging was done
> > (i.e. tagging freeze is lifted)
>
> Forget about that patch, while I tried to fixup behind kate (which
> introduced various whitespace changes for no reason) I missed a small
> part.
>
> Updated patch which actually does compile.
>
> Andreas

-    while( list.first())
-        delete list.first();
+    if( !list.isEmpty() )
+        {
+            while( list.first())
+            delete list.first();
+        }

This doesn't make sense. Either the original code was fine, or this is broken 
as well. Just using qDeleteAll() should fix this.

-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l.lunak at suse.cz , l.lunak at kde.org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http//www.suse.cz