[PATCH] sorted kfiletreeviews

David Faure faure at kde.org
Tue Dec 4 12:10:21 GMT 2007


On Sunday 02 December 2007, Rafael Fernández López wrote:
> Hi,
> 
> First of all, thank you very much for taking a look. From what I see on the 
> patch, it seems to be nice.

Which patch? I don't see Benjamin's patch in my inbox or on kde-core-devel...

> We can fix this on the tree view too, but from what I see, the real problem 
> lives on KDirModel. KDirModel when being called expandTo() if it goes through 
> folders that hasn't been cached before it won't cache them, and just think 
> that they have 0 elements.

The idea of expandTo is to be asynchronous... it emits a signal once it can expand to the
requested url.

> Let's wait for David to see what he thinks about this issue. :)

I'll have a look but let me tell you already: I completely veto your event-loop hack.
It makes the stuff blocking (bad!) while it has always meant to be asynchronous.
So my gut feeling is that kfiletreeview is using KDirModel wrongly, if it assumes it to be
synchronous.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list