Missing KCompletionMatches copy operator

Allen Winter winter at kde.org
Mon Dec 3 14:28:49 GMT 2007


On Sunday 02 December 2007 16:26:14 Christian Ehrlicher wrote:
> Hi,
> 
> due to a missing copy operator I get a crash (on windows) when konqueror
> tries to display historyPopupCompletionItems.
> It happens because msvc (don't know if/how this works with gcc) creates
> a default copy ctor which does not copy the d-ptr correctly -> double
> free d-ptr -> crash.
> 
On Linux, I see crashes in Konqueror's location bar very often.

> Afaics therer are also other classes which have d-ptr but no copy ctor
> (at least KCompletionBase and KCompletion).
> 
> The attached patch fix the issue for KCompletionMatches.
> 
I think use Q_DISABLE_COPY() in these classes until someone comes
up with a case where copy is needed.








More information about the kde-core-devel mailing list