[PATCHES] KCModule changes and kutils fixes

Matthias Kretz kretz at kde.org
Sat Aug 25 13:06:52 BST 2007

On Tuesday 21 August 2007, Rafael Fernández López wrote:
> ## kutilsfix.diff ##
> It fixes the forcing of a library containing a KCModule to start by kcm_. I
> removed that requirement a week ago or so. I didn't see this code, and now
> this is fixed too.

-  libname = "kcm_%1";
+  libname = "%1";

make that

-  libname = "kcm_%1";
-  loader->unloadLibrary(libname.arg(mod.library()));
+  loader->unloadLibrary(mod.library());

looks good otherwise except that this code could use some more cleanup...

> ## kdelibs.diff ##

I'm not so happy about adding the init method. For this particular case I'd 
really favor to add the line
QTimer::singleShot(0, this, SLOT(changed()));
to the constructor. What is "conditional to the system" about that?

Do you see other use cases for the init method than the one you described?

Another approach would be to call load() from KCModuleProxy in the place where 
you call init(). Actually that's how I'd like the KCModule interface to work, 
but that's a pain to fix in all the KCMs where you have to remove the load() 
call from their ctor.

Matthias Kretz (Germany)                            <><
MatthiasKretz at gmx.net, kretz at kde.org,
Matthias.Kretz at urz.uni-heidelberg.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070825/89b856fc/attachment.sig>

More information about the kde-core-devel mailing list