[PATCH] New signal for KKeySequenceWidget

Thomas McGuire thomas.mcguire at gmx.net
Mon Aug 20 21:43:42 BST 2007


attached a patch which adds a new signal to KKeySequenceWidget. This signal is 
like the existing keySequenceChanged() signal, just with more parameters.

The new parameters include the old key sequence and a boolean flag wether the 
key sequence was changed programmatically or by the user.

This is necessary to correctly port the usages of KKeySequenceWidget. 
Currently, the code using the widget is incorrect, because it relies on the 
fact that the new key sequence is not yet set when the signal is emitted. 
This is however not the case anymore with the new KKeySequenceWidget.
Because of this, reverting to the old shortcut if a conflict occurs is not 

A quick look at lxr.kde.org reveals that all users outside of KDEUI are 
currently incorrect and could benefit from the new signal.

Attached also a sample change of one of the four usages in KMail.

OK to commit next Monday (27th)?
(if there are no objections, I'll commit)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: kksw.diff
Type: text/x-diff
Size: 2806 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070820/40a8517f/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kmail.diff
Type: text/x-diff
Size: 2324 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070820/40a8517f/attachment-0001.diff>

More information about the kde-core-devel mailing list