[PATCH] Kate EBN fixes

Christoph Cullmann cullmann at absint.com
Mon Apr 23 06:26:16 BST 2007


On Monday 23 April 2007 01:00, Alex Merry wrote:
> This is a bunch of changes making constructors explicit.  There's no
> obvious reason for any of these constructors not being explicit, and it
> all (including kdesdk/kate) compiles fine, but I just thought I'd check
> before committing.
Looks OK, thx, commit if you want ;)

>
> I didn't change the KateHlContextModification constructor in
> katehighlight.h, since katehighlight.cpp makes extensive use of the
> implicit constructor.  I can look at changing that code if anyone
> thinks it's worth it.
Guess would be no bad idea, this class I hacked up as soon as it became clear 
a pure int won't be enough for context modifications, had not taken that much 
time to make it more usable, guess explicit constructor would make it's usage 
at some places more clear ;)

cu
Christoph

-- 
-------------------------------------- Christoph Cullmann ---------
AbsInt Angewandte Informatik GmbH      Email: cullmann at AbsInt.com
Science Park 1                         Tel:   +49-681-38360-22
66123 Saarbrücken                      Fax:   +49-681-38360-20
GERMANY                                WWW:   http://www.AbsInt.com
--------------------------------------------------------------------
Geschäftsführung: Dr.-Ing. Christian Ferdinand
Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234




More information about the kde-core-devel mailing list