3.5.5: please review nasty API change in wireless extensions

Thiago Macieira thiago at kde.org
Thu Sep 28 18:42:23 BST 2006

Stefan Winter wrote:
>-  wrq.u.essid.pointer = (caddr_t) WIFI_CONFIG(info,essid);
>+  /* prepare NULL-terminated buffer in case the string returned by
>SIOCGIWESSID is NOT NULL-terminated */
>+  memset(wrq.u.essid.pointer, '\0', IW_ESSID_MAX_SIZE + 1);

Looks sane, but is wrq.u.essid.pointer always guaranteed to be 
IW_ESSID_MAX_SIZE + 1 or more?

  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060928/65f988fb/attachment.sig>

More information about the kde-core-devel mailing list