kdemultimedia3 - patch to fix lockup of audiocd:/ kioslave

Thomas Braxton brax108 at cox.net
Fri Sep 22 23:19:46 BST 2006


On Friday 22 September 2006 06:08, Tilman Vogel wrote:
> +       if(drive->ioctl_device_name && strlen(drive->ioctl_device_name))
> +         d->cd.setDevice(drive->ioctl_device_name, 50, false);
> +       else
> +         d->cd.setDevice(drive->cdda_device_name, 50, false);
couldn't this be changed to:

if(drive->ioctl_device_name && drive->ioctl_device_name[0])
  d->cd.setDevice(drive->ioctl_device_name, 50, false);
else
  d->cd.setDevice(drive->cdda_device_name, 50, false);

why compute the length of the string if you only care if it's empty or not.




More information about the kde-core-devel mailing list