KDE/kdelibs/cmake/modules

[Allen Winter]

On Thursday 07 September 2006 17:24, Alexander Neundorf wrote:
> On Thursday 07 September 2006 20:33, Alexander Neundorf wrote:
> > On Thursday 07 September 2006 10:20, David Faure wrote:
> > > On Wednesday 06 September 2006 22:37, Oswald Buddenhagen wrote:
> > > > On Wed, Sep 06, 2006 at 10:00:32PM +0200, Alexander Neundorf wrote:
> > > > > On Wednesday 06 September 2006 21:37, Oswald Buddenhagen wrote:
> > > > > > it's not okay to have a license only in kdelibs and refer to it
> > > > > > from the other tar-balls. things are probably different for svn and
> > > > > > they *are* different for split-up packages. point is, every
> > > > > > separately distributed entity must carry a full license. and you
> > > > > > may not assume on-line access - it must be on the same medium as
> > > > > > the licensed material itself.
> > > > >
> > > > > How about putting a COPYING-CMAKE-SCRIPTS (which contains the BSD
> > > > > license) in every modules in the same directory as the cmake scripts
> > > > > and then reference it in every file ?
> > > >
> > > > i'm pretty sure that's fine
> > >
> > > OK.
> >
> > Ok, I'll do that.
> 
> Done for FindKDE4Internal.cmake.
> 
> In the cmake file it now reads as:
> 
> # Copyright (c) 2006, Alexander Neundorf <neundorf at kde.org>
> # Copyright (c) 2006, Laurent Montel, <montel at kde.org>
> #
> # Redistribution and use is allowed according to the terms of the BSD license,
> # for details see the accompanying COYPING-CMAKE-SCRIPTS file.
                                                         ^^^ COPYING-CMAKE-SCRIPTS^^

I'd rather see two separate sentences:
# Redistribution and use is allowed according to the terms of the BSD license.
# For details see the accompanying COPYING-CMAKE-SCRIPTS file.

> 
> with COPYING-CMAKE-SCRIPTS:
> 
> --------8<--------------8<-----------------8<----------------8<--------------
> 
> Redistribution and use in source and binary forms, with or without
> modification, are permitted provided that the following conditions
> are met:
>
> 1. Redistributions of source code must retain the above copyright
>    notice, this list of conditions and the following disclaimer.
> 2. Redistributions in binary form must reproduce the above copyright
>    notice, this list of conditions and the following disclaimer in the
>    documentation and/or other materials provided with the distribution.
> 3. The name of the author may not be used to endorse or promote products
>    derived from this software without specific prior written permission.
> 
> THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
> IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
> OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
> IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
> INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
> NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
> THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> 
> --------8<--------------8<-----------------8<----------------8<--------------
> 
> Is it a problem that the license says: "above copyright notice", but since 
> this is an extra file, there is no copyright notice above, but in an extra 
> file ?
Remove the word "above" from the COPYING-CMAKE-SCRIPTS  file.

> Is it ok that the short statement does't say "in source or binary form" ? (how 
> should a cmake script in binary form look like ?)

I think it is ok.


-- 
KDE: Same Thing We Do Everyday... Try to Conquer the World