kjs includes

[Harri Porten]

On Wed, 25 Oct 2006, Sebastian Sauer wrote:

> some of the installed headers like kdelibs/kjs/function.h does
> #include "internal.h" while internal.h is not installed.

Hmm. In trunk that's true but should not be the case. Looks like whatever 
is required from internal.h should be moved out from there. Can't do this 
myself this week unfortunately.

> This prevents to #include <kjs/function.h>. Also kjs/function_object.h 
> is not installed and judging from e.g. Kate's katejscript.* software 
> that likes to use kjs may like to include those files.

I wonder what function_object.h is really used for. I only took a quick 
glance at the code online but saw no references.

>
> So, change CMakeLists.txt to install
> kjs/internal.h+kjs/function_object.h+kjs/object_object.h+whatever else files
> are missing?
>
> or is it wanted to don't use such kjs-functionality in future outside of
> kdelibs? or did I miss there something else?

There are plans to make KJS semi-private API of kdelibs. But that should 
not be a reason to not make it have a proper interface. I.e. the 
distinction between public and private headers should be enforced.

Harri.