Some remarks on kdebase revision 595286

[Lubos Lunak]

On Saturday 14 October 2006 01:09, Christoph Bartoschek wrote:
> - kdebase/workspace/kwin/lib/kcommondecoration.h:262
Fixed.
> - khotkeys/shared/voicesignature.cpp:127
> Maybe not possible: If sound.size() == 0 and start = stop -1 then
> log2size is 65535 here and outside of the allowed shift range.
No idea, but added a check.
> - khotkeys/shared/input.cpp:216
> x_mod and keysym are never assigned. But they are used here.
There's "return false;" at the very beginning, the function needs more fixing.
> - khotkeys/kcontrol/condition_list_widget.cpp:287
> Line 272/273 suggests that parent2_P could be NULL here.
Only if the other parent is not NULL.

-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l.lunak at suse.cz , l.lunak at kde.org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http//www.suse.cz