KPageWidget

[Tobias Koenig]

On Sun, Nov 26, 2006 at 11:20:40PM -0800, Charles Samuels wrote:
Hi Charles,

> KPageWidget has these ctors:
> 
> public explicit KPageDialog( QWidget *parent = 0, Qt::WFlags flags = 0 );
> protected KPageDialog( KPageWidget *widget, QWidget *parent=0, Qt::WFlags=0 );
> 
> When trying to call the first constructor with a KPageWidget, there is an 
> ambiguity (This is a rare case).
Hmm, since the second one is protected an external instanciation of a
KPageDialog should always use the first ctor. The second one is only
used when you inherit from KPageDialog, in this case you just supply all
the parameters from your implementation:

MyDialog::MyDialog( QWidget *parent, Qt::WFlags flags )
  : KPageDialog( new MyPageWidget, parent, flags )
{
}

So I can't see any ambiguity...

> the function:
>     KPageWidget *pageWidget() const;
> 
> Should probably not be const. There should probably be a const and non-const 
> version of that function.
Why?

> Or is this email off-topic because it's not about PDF readers?
Yeah, right, you should at least mention that okular uses KPageDialog in
its configuration dialog as well...

Ciao,
Tobias
-- 
Separate politics from religion and economy!
The Council of the European Union is an undemocratic and illegal institution!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20061127/d814728b/attachment.sig>