Kicker crash with compiz

[Andras Mantia]

On Thursday 25 May 2006 20:10, Andras Mantia wrote:
> Isn't it so, that now I cannot reproduce? I will run kicker in
> valgrind as soon as it crashes, I promise.

I was too fast. Kicker does not crash in valgrind, this is the simple 
truth. But it crashes in real life. The full log is attached. First 
there is a crash without valgrind (you can see those X errors), later 
inside  valgrind. There the interesting part starts from the lot of 
"empty" lines:

andris at stein:/data/home/andris>
andris at stein:/data/home/andris>
andris at stein:/data/home/andris>
andris at stein:/data/home/andris>
andris at stein:/data/home/andris>
andris at stein:/data/home/andris>
andris at stein:/data/home/andris>
andris at stein:/data/home/andris>
andris at stein:/data/home/andris>
andris at stein:/data/home/andris> ==9679==
==9679== Invalid read of size 8
=

It seems that QXEmbed is indeed deleted and used later. My suspicion is:
QXEmbed line 1056:
emit embeddedWindowDestroyed();

This triggers SystemTrayApplet::updateTrayWindows() which deletes an 
object (and a QXEmbed object as well!). From this line down in QXEmbed 
the object does not exist anymore so sooner or later kicker will crash. 
Maybe using deleteLater instead of "delete *emb;" in 
SystemTrayApplet::updateTrayWindows() is enough. Let's try it...
Yeah, I cannot reproduce anymore. 
Fix attached. I don't claim it fixes all the bugs listed in the report, 
but if you think it is, I commit and close the report (just to get some 
fame). ;-)

Andras


-- 
Quanta Plus developer - http://quanta.kdewebdev.org
K Desktop Environment - http://www.kde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kicker.log.bz2
Type: application/x-bzip2
Size: 4736 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060525/b2cb00f5/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: systrayfix.diff
Type: text/x-diff
Size: 700 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060525/b2cb00f5/attachment.diff>