cmake 2.4.2 stable released

[Alexander Neundorf]

Hi,

On Thursday 18 May 2006 11:39, you wrote:
> > From: Alexander Neundorf [mailto:neundorf at kde.org]
> >
> > On Wednesday 17 May 2006 23:59, you wrote:
> > > On Wednesday 17 May 2006 21:16, Alexander Neundorf wrote:
> > > > Hi,
> > > >
> > > > On Wednesday 17 May 2006 22:07, you wrote:
> > > > ...
> > > >
> > > > > We need this patch to use 2.4.2,
> > > > >
> > > > > Index: cmake/modules/KDE4Macros.cmake
>
> ===================================================================
>
> > > > > --- cmake/modules/KDE4Macros.cmake      (Revision 541949)
> > > > > +++ cmake/modules/KDE4Macros.cmake      (Arbeitskopie)
> > > > > @@ -497,7 +497,7 @@
> > > > >     endif (${second_PARAM} STREQUAL "RUN_UNINSTALLED")
> > > > >
> > > > >     if (NOT "${remove}" STREQUAL "NOTFOUND")
> > > > > -      list(REMOVE_ITEM ${_output_LIST} ${remove})
> > > > > +      list(REMOVE_AT ${_output_LIST} ${remove})
> > > > >     endif (NOT "${remove}" STREQUAL "NOTFOUND")
> > > > >
> > > > > but it will break the 2.4.1 usage. Is there a cmake version
> >
> > variable.
> >
> > > > I think your kdelibs is way too old ;-)
> > > > It works with both.
> > >
> > > Not here, on a windows box with a fresh kdelibs update.
> >
> > Where does it complain ?
> > And you have current kdelibs trunk ?
>
> Yes, both Peter and I are trying with trunk on windows of course.
...
> Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .h++ .hm .hpp
> .hxx .in .t xx CMake Error: Cannot find source file
> "D:/kde/kdelibs/dcop/client/NOGUI" for targ et "dcop_executable"
> [...]
>
> Peter patch fixes this.

Can you please run cmake on the attached file and post the output here ?

Thanks
Alex
-- 
Work: alexander.neundorf AT jenoptik.com - http://www.jenoptik-los.de
Home: neundorf AT kde.org                - http://www.kde.org
      alex AT neundorf.net               - http://www.neundorf.net
-------------- next part --------------
# the behaviour of LIST(REMOVE_ITEM ... ) changed from 2.4.1 beta to 2.4.2 stable
# detect this here
# this can be removed once we require cmake >= 2.4.2
set(remove_item_test_list one two)
message(STATUS "list: ${remove_item_test_list}")
# with cmake 2.4.1 this means remove index 0, 
# with >= 2.4.2 this means remove the items which have the value "0"
list(REMOVE_ITEM remove_item_test_list 0)
message(STATUS "list: ${remove_item_test_list}")
list(LENGTH remove_item_test_list _test_list_length)
# so with 2.4.1 the list will have only one item left, with 2.4.2 two
message(STATUS "list after remove: length: ${_test_list_length}")
if (${_test_list_length} EQUAL 2)
   set(_REMOVE_AT_INDEX_KEYWORD REMOVE_AT)
else (${_test_list_length} EQUAL 2)
   set(_REMOVE_AT_INDEX_KEYWORD REMOVE_ITEM)
endif (${_test_list_length} EQUAL 2)

message(STATUS "remove index from list: ${_REMOVE_AT_INDEX_KEYWORD}")