change in KFileFilter?

[David Faure]

On Tuesday 16 May 2006 22:52, Jens Herden wrote:
> Hi,
> 
> looking into KFileFilter I found:
> 
> setNameFilters( const QString& nameFilters, Qt::CaseSensitivity caseSensitive 
> = Qt::CaseSensitive, const QChar& separator = ' ' );
> 
> I'd like to change this to accept a QStringList instead of a QString and a 
> separator because there is also setMimeFilters which works this way and I 
> think the API should be consistent here. And QDir has a method with the same 
> name which also accepts a QStringList.
> 
> Is this OK?

Yep.

> If yes, can I just change the method or should I deprecate it and create a new 
> one?

If you port the code that uses this method, in the rest of kdelibs [including unit tests],
feel free to just change the method.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).