KProcess overhaul [PATCH]
Thiago Macieira
thiago at kde.org
Tue May 16 11:54:53 BST 2006
The ones that I didn't list can use Q_PID as it is. There's no need to
access the process ID itself.
Ralf Habacker wrote:
>./kio/kio/krun.cpp: if ( !process_->pid() )
>./kio/kio/krun.cpp: if ( !process_->pid() )
>./kio/kio/krun.cpp: if ( !binName.isEmpty() && ( showErr ||
>process_->pid() == 0 ) )
These are relying on fork() behaviour. They have to be changed.
>./kio/kio/slave.cpp: slave->setPID(proc.pid());
Not sure, but maybe Q_PID can work here.
>./khtml/test_regression_gui_window.cpp:
>kill(m_activeProcess->pid(), SIGSTOP);
Unix-specific.
>./khtml/test_regression_gui_window.cpp:
>kill(m_activeProcess->pid(), SIGCONT);
Unix-specific.
>./kdeprint/kdeprintd.cpp: return ( int
> )proc->pid();
Can be changed to Q_PID.
--
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
thiago.macieira (AT) trolltech.com Trolltech AS
GPG: 0x6EF45358 | Sandakerveien 116,
E067 918B B660 DBD1 105C | NO-0402
966C 33F5 F005 6EF4 5358 | Oslo, Norway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060516/973f4cb9/attachment.sig>
More information about the kde-core-devel
mailing list