Proposal: Extended Attribute support in Kioslave: File

[Adriaan de Groot]

On Friday 05 May 2006 08:31, Daniel Nakata wrote:
> As an initial step toward my goal of saturating KDE with support for
> extended attributes, I'd like to suggest the following modifications to the
> kdelibs codebase:
>
> 1) Add --enable-xattr to configure(.in(.in)), and have it define
> HAVE_XATTR, if -lattr works (libattr is available).  If so, add "-lattr" to
> LIBS.

This suggests you're talking about KDE 3; I don't think such a big feature is 
a good idea in a feature-frozen branch. For KDE 4, this makes sense (but it 
doesn't *have* configure(.in(.in)) so keep that in mind).

> 2) Conditionally #include<attr/xattr.h>, if xattr is enabled, in
> kioslaves/file/file.cc

Or extattr.h .

> How does this sound?  I'm willing to write it up if there's a chance it
> would make it into KDE officially.

The main issue I'd have with this is non-Linux compatibility. From the single 
example you give, fgetxattr() is very much like getattr_get_fd() in API, so 
it's doable. Remember to leave the interfaces sufficient flexibility that the 
*can* be filled in for non-Linuxen.

-- 
These are your friends - Adem
    GPG: FEA2 A3FE Adriaan de Groot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060505/e0afe02b/attachment.sig>