change bool to enum : KUrl
faure at kde.org
Tue May 2 14:42:30 BST 2006
On Tuesday 02 May 2006 07:46, Simon Hausmann wrote:
> On Tuesday 02 May 2006 07:37, Simon Hausmann wrote:
> > On Tuesday 02 May 2006 07:09, Olivier Goffart wrote:
> > Also for QueryItemsOption I think LowerCaseKeys is a better name than
> > CaseInsensitiveKeys, since lower casing is exactly what the option does,
> > while with CaseInsensitiveKeys one might wonder if it adds each key twice
> > in the map, once upper and once lowercase. Lower case is also used in the
> > documentation of the option.
> Actually, why does KUrl::queryItems still exist in the first place? :)
> Is the lowercasing really worth having an extra method that has a different
> return type, creating a conflict with one of the 8 methods in QUrl dedicated
> to query item handling?
Because decoding '+' to ' ' (which is necessary for HTTP)
was deemed to be "not the task of QUrl" by the QUrl maintainer, so I do it in KUrl.
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
More information about the kde-core-devel