KWin KPixmap removal

[Thiago Macieira]

Frans Englich wrote:
>> That was completely unnecessary. The only reason to change all include
>> style in a file is if it's a public header and it doesn't use the Qt
>> module name. All public headers should include the Qt headers in the
>> long form (e.g., QtGui/qpixmap.h or QtGui/QPixmap).
>
>Cannot this be enforced by only having QTDIR/include among the includes?
>Otherwise I do not see how it will be followed.

That's true. But I'm asking that people make that effort so that our 
headers can be used by applications that only have QTDIR/include.

Then again, I think we can come up with something so that the EBN reports 
those issues.

>(Same goes with Q_SLOTS/Q_SIGNALS, imho. I think "slots" and "signals"
> will slip into kdelibs unless Q_NO_KEYWORDS is defined.)

That can be checked in an automated fashion.

#define Q_NO_KEYWORDS
#define signals choke
#define slots choke
#define foreach choke

#include "all_headers.h"

-- 
Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
  thiago.macieira (AT) trolltech.com     Trolltech AS
    GPG: 0x6EF45358                   |  Sandakerveien 116,
    E067 918B B660 DBD1 105C          |  NO-0402
    966C 33F5 F005 6EF4 5358          |  Oslo, Norway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060502/93926d34/attachment.sig>