change bool to enum : KUrl

[Matt Rogers]

On Monday 01 May 2006 17:44, Olivier Goffart wrote:
> (Note: i resent this message because it seems the original was lost, sorry
> if you get it twice)
>
> Hi.
>
> So I'm trying to change function that are taking boolean argument to a
> QFlags or an enum.
>
> egrep "\(.*bool[^*&]{2}" *.h | grep -v set | grep -v KDE_DEPRECATED
>
> That command give a list of function that most probably should be changed
> (in the current directory).
>
> So i have done KUrl changes.
> (path kurl.diff attached)
>
> I've also ported the kdelibs trunk to theses changes. (not attached)
> Although i don't know perl, I've tried to made some change automatic.
> (patch convert-url attached)
>
> If no objection, I will commit.


some of the enum names could be better. I would change the following to 
provide better naming:

CleanDirSeparator -> SimplifyDirSeparators (CleanPathOption)
AppendTrailingSlashToResult -> AppendTrailingSlash (DirectoryOption enum)
IgnoreFragment -> IgnoreHtml (EqualsOption enum)

my 2c,
Matt