[PATCH] KSpell2 improvement

[Nicolas Goutte]

On Monday 13 March 2006 20:33, Mashrab Kuvatov wrote:
> On Monday 13 March 2006 15:21, Thiago Macieira wrote:
> > "extract" means: find them all and construct a list like:
> >
> > static const char *extensionList[2][] = {
> >   { "ise", I18N_NOOP("-ise suffixes") },
> >   { "ize", I18N_NOOP("-ize suffixes") },
> >   { "wo_accents", I18N_NOOP("without accents") },
> >   ...
> > };
>
> I made such changes. Please have a look.

The patch is not good i18n-wise.

I suppose that you need to use I18N_NOOP2 with a context, as some of the 
strings are quite common (especially "small", "medium", "large").

Do not forget that if you use I18N_NOOP2, you need to ue the same context when 
calling i18n() with those strings.

As for the generic "%1 %2 %3" type of strings, that is probably too raw for 
the translators too. So here too a short context would be need to avoid 
clashes with other KDE messages and perhaps a comment starting with
//i18n: 
and explaining a little the string is needed. (The comment is a translator 
hint and need to be before the i18n() (or I18N_NOOP).)

>
> > Exactly: the method is called every time an item is selected. And
> > building this list is an expensive operation. Just save it in a variable
> > the first time you're called.
>
> I need help here.
>
> Cheers,
> Mashrab.

Have a nice day!