FEATURE: Merge Hal changes

[Kevin Ottens]

Le mercredi 7 juin 2006 10:01, Thiago Macieira a écrit :
> So you're saying Kévin reviewed you changes? If so, we've got two of the
> required rules met. (the other being the "well tested" rule)

Yes, I took a look at it, but I didn't have time to make a close review until 
recently. I even took some time to triage bugs related to kio media. And here 
are the reports addressed by coolo's branch:

http://bugs.kde.org/show_bug.cgi?id=50185
http://bugs.kde.org/show_bug.cgi?id=105482
http://bugs.kde.org/show_bug.cgi?id=108823
http://bugs.kde.org/show_bug.cgi?id=114854
http://bugs.kde.org/show_bug.cgi?id=120619
http://bugs.kde.org/show_bug.cgi?id=121833
http://bugs.kde.org/show_bug.cgi?id=127788

No less... I merged this branch in my working copy and only had to make a few 
adjustments (patch against coolo's branch attached), they are mostly about 
removing some SUSE specific bits (I expected to find more of them 
honestly ;-) ) and the default automount policy so that it matches the 
current default behavior (no automount enabled by default, I'm reluctant to 
change this for the 3.5.3->3.5.4 transition).

Actually merging this branch would let me only four reports to address before 
being ready for 3.5.4 IMO:

http://bugs.kde.org/show_bug.cgi?id=112826
http://bugs.kde.org/show_bug.cgi?id=116209
http://bugs.kde.org/show_bug.cgi?id=117623
http://bugs.kde.org/show_bug.cgi?id=128754

If no one objects I'll commit my working copy (on monday or tuesday) making 
the merge effective, and work on the four remaining reports I listed above.

> As for the "it must be in trunk already" request, I don't think it would
> apply here. Kévin is working on Solid, which will replace the whole
> thing.

Yes, definitely, lot of code from the mediamanager will be rewritten. As for 
the other parts, some might still exist for KDE4, but I'd prefer to 
forwardport by hand anyway, since it'll also be impacted by Solid.

Regards.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: coolos_media_premerge.patch
Type: text/x-diff
Size: 4648 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060610/e1d8acea/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060610/e1d8acea/attachment.sig>