error compiling KDE4 base ksysguard

[David Faure]

On Saturday 22 July 2006 18:27, Martin Koller wrote:
> Hi list,
> 
> I'm trying to compile current kdebase but get the following strange error.
> I tried to find the problem in the code, but it seems I'm blind ...
> Any ideas ?

KFileDialog dlg( QString(), ... )
doesn't compile with gcc-3.something.

It's a complex C++ parsing issue, where the above could be either nested 
constructors (as the author intended) or a function declaration.
Although in most cases, because of the extra arguments (the "..."), it can't be
a function declaration, but gcc-3 doesn't notice that, only gcc-4 does.

The fix/workaround is to avoid nested constructors (when the first argument
is a constructor, like in the above case). E.g. by using QString:null.

In this particular case (Workspace.cc) the code had other issues though
(creating an instance and then calling a static method on it?? Huh), so I'm fixing
it differently.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).