kdelibs coding style

[Maks Orlovich]

On Saturday 22 July 2006 22:14, Thiago Macieira wrote:
> Maks Orlovich wrote:
> >Sure, but I would say nearly all of these above have clear, unambiguous
> >benefits. Having someone change where the braces are in Keramik or how
> > many spaces khtml/ecma is indented with doesn't.
>
> You'll allow me to disagree. I'd say that there are clear benefits for
> readability and maintainability of code.

There are clear benefits to nice indentation, yes. There are no clear benefits 
to using indentation X and not indentation Y for new code, and messing up 
indentation Y in existing code. Notice that I never objected to saying: if 
file Z is a mess, we suggest you use rules X. Now, I might prefer something a 
bit more decentralized, but that's sort of not a big deal.

> Now, how should we decide this? It's clear that the entire KDE community
> is not at issue here. 

Again, I would say that entire KDE community is at issue, since it's about 
instituting a manner of instituting a policy, etc.

>
> Do you want to put this to a vote? Then we need to define who should vote.

I would prefer some concensus based protocol. I have stated my concerns (you 
could probably say I did that somewhat poorly), and will largely shut up now. 
I'll leave it up to people who push this policy to decide which of my 
concerns, if any, they  give a damn about, and will leave it to myself to 
decide how much I give a damn about the proposal. 

>
> If it's not a vote, I'd say there is a clear majority in this discussion
> favouring the proposal.

I am not sure that this is indicative of anything. After all, I know that 
people have stated their oppositing to the idea on IRC, but have refrained 
from commenting because they feel that they are not kdelibs hackers and 
should not be involved. However, I see some of the more vehement pro-proposal 
posters on this thread haven't actually done much with kdelibs, either. 

> BTW, since I am the KNetwork maintainer and only author, I am imposing the
> proposed indentation style to my own existing and future code. 

That's certainly your choice. 

> And I 
> suggest to Matthias Kretz that he do the same to Phonon too, and George
> to kwallet, etc. Maybe if we've got enough critical mass, it'll just look
> pointless to have a few files looking different from the rest. It doesn't
> have to be a top-down decision: it can be bottom-up.

I have absolutely no problem with bottom-up stuff like that.