Endian bug in KNetwork::KIpAddress

[Thiago Macieira]

Nadeem Hasan wrote:
>On Saturday 22 July 2006 09:18, Thiago Macieira wrote:
>> Please don't #include <arpa/inet.h> in the public header.
>>
>> Add a new function that returns the ntohl of the IPv4 address and call
>> ntohl from it.
>
>Try #2.
>
>I had to use the underscore as ntohl() is defined as a macro.

It would be much simpler if it were just one function. The way it is 
constructed, the inlined function places two function calls. If it were 
one single function that returns the host-ordered IPv4 address, it would 
be one single function call.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060722/82ce5721/attachment.sig>