KButtonBox port to QDialogButtonBox
Olivier Goffart
ogoffart at kde.org
Sun Jul 16 14:15:14 BST 2006
Hello.
Does this patch make sens:
It make KButtonBox inherit QDialogButtonBox. This allow to remove most of the
code of KButtonBox itself.
Porting application is easy, and just require to add the button role parameter
(usually ActionRole). Or, in some case, use KDialog button instead.
I did not remove completely KButtonBox in favor of the Qt equivalent because
of the KGuiItem support.
The possibility to connect directly to a slot on the button creation is also a
nice feature, that could maybe eventually go in Qt
Anyway, maybe we should rename it KDialogButtonBox ?
(but i did not to make porting easier)
Ok to commit ?
--
Olivier (aka Gof)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kbuttonbox.diff
Type: text/x-diff
Size: 14293 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060716/562096fd/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060716/562096fd/attachment.sig>
More information about the kde-core-devel
mailing list